David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 )
Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 ...................................................................... Patch Set 6: > Patch Set 6: > > Agree it would be good to sanity check at least one large query. Otherwise > this looks good to me. Sadly, it looks like performance of 0.3.1 is a bit slower. I'm using test_large_sql to measure. Since there are no leading comments in the generated file, I'm presuming that it has nothing to do with the changes I made to that filter. # sqlparse-0.1.19 Time to parse large sql: 0.841411113739 Time to parse large sql: 0.83651804924 Time to parse large sql: 0.850656032562 Time to parse large sql: 0.853680849075 Time to parse large sql: 0.841284036636 Time to parse large sql: 0.856855869293 Time to parse large sql: 0.856756210327 Time to parse large sql: 0.85582280159 Time to parse large sql: 0.843133926392 # sqlparse-0.3.1 Time to parse large sql: 0.972465991974 Time to parse large sql: 0.965172052383 Time to parse large sql: 0.977255105972 Time to parse large sql: 0.964542865753 Time to parse large sql: 0.955338954926 Time to parse large sql: 0.96136713028 Time to parse large sql: 0.976768016815 Time to parse large sql: 0.96532201767 Time to parse large sql: 0.959042072296 Going to dig into this a bit to see if there's anything we can do, but I'm doubtful, since it's presumably internal to the library. -- To view, visit http://gerrit.cloudera.org:8080/15642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 19:01:43 +0000 Gerrit-HasComments: No
