[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 )
Change subject: IMPALA-9428 Add arm64 atomic ops ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG@13 PS18, Line 13: Here add arm64 atomic ops implementation. > Can you mention where you got the implementations from? I.e. which reposito Hi, Tim, it is originally from here:https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc. And I changed something for newer instructions and for adapt impala http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/common/init.cc@307 PS16, Line 307: #ifndef THREAD_SANITIZER : #ifndef __aarch64__ > nit: Instead of nested ifndefs, can it be the following? Yes, Zoltan, Of course, it can be http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/gutil/cpu.cc File be/src/gutil/cpu.cc: http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/gutil/cpu.cc@274 PS16, Line 274: has_broken_neon_ = false; > Could you add a comment about why can we set it to false here? Hi, Zoltan, broken neon is a bug of an old arm cpu, and it is 32bit cpu. Aarch64 cpu don' t have this issue. You can find details here: https://code.google.com/p/chromium/issues/detail?id=341598 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 12:44:17 +0000 Gerrit-HasComments: Yes
