Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 )
Change subject: IMPALA-9428 Add arm64 atomic ops ...................................................................... Patch Set 20: (2 comments) OK, I'm pretty much ready to +2, just had a minor request. http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG@13 PS18, Line 13: Here add arm64 atomic ops implementation. > Hi, Tim, it is originally from here:https://github.com/protocolbuffers/prot Ok cool, I did a diff against that version to review it. I think it would ultimately be nice to update to use chromium's platform-independent versions - I filed IMPALA-9623 for that. But this approach is consistent with the current codebase so OK for now. http://gerrit.cloudera.org:8080/#/c/15300/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/20//COMMIT_MSG@10 PS20, Line 10: Can you include a link to the protobuf repo and mention the commit hash that you got it from. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 17:00:13 +0000 Gerrit-HasComments: Yes
