Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15693 )
Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed ...................................................................... Patch Set 1: Code-Review+2 (2 comments) The fix makes sense to me. http://gerrit.cloudera.org:8080/#/c/15693/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15693/1//COMMIT_MSG@16 PS1, Line 16: This causes problems because : a rewrite rule (invoked by SelectStmt.rewriteExprs()) may try to : process the original grouping exprs and encounter INVALID_TYPE : (types are only assigned after analyze) Is ConvertToCNFRule the only rewrite rule that requires Exprs are analyzed? http://gerrit.cloudera.org:8080/#/c/15693/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/15693/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@690 PS1, Line 690: in case we need to print them later nit: Looks like we only print them at line 700. Maybe we can make this comment more concrete. -- To view, visit http://gerrit.cloudera.org:8080/15693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6da4a17c6e648f466ce118c4646520ff68f9878e Gerrit-Change-Number: 15693 Gerrit-PatchSet: 1 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2020 05:58:09 +0000 Gerrit-HasComments: Yes
