Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15693 )
Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed ...................................................................... Patch Set 2: Code-Review+2 (2 comments) The solution looks good to me. http://gerrit.cloudera.org:8080/#/c/15693/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/15693/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@710 PS2, Line 710: groupingExprs_ = groupingExprsCopy_; As offline discussed, this may affect the result of toSql(). However, it's just the difference between non-analyzed and analyzed Exprs. I gone throught all subclasses of Expr. None of their toSqlImpl() depends on analyzed results. So I think this is ok as long as no rewrites happen at this place. http://gerrit.cloudera.org:8080/#/c/15693/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java File fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java: http://gerrit.cloudera.org:8080/#/c/15693/2/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@112 PS2, Line 112: cpred.getIds(tids, null); Another solution is do cpred.analyze() here if it's not analyzed. Not a blocker. We can consider this later. -- To view, visit http://gerrit.cloudera.org:8080/15693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6da4a17c6e648f466ce118c4646520ff68f9878e Gerrit-Change-Number: 15693 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2020 09:22:14 +0000 Gerrit-HasComments: Yes
