Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15689 )
Change subject: IMPALA-9625: Convert fully-qualified table name to lowercase in getTable() ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Hi Fang-Yu, left some comments, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/15689/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/15689/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2758 PS1, Line 2758: public void addAccessEvent(TAccessEvent event) { I think it would be safer to check if the name is lower case here with a precondition. Another option is to convert the name to lower case here. http://gerrit.cloudera.org:8080/#/c/15689/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2949 PS1, Line 2949: globalState_.accessEvents.add(new TAccessEvent( Here we should also use the addAccessEvent method. -- To view, visit http://gerrit.cloudera.org:8080/15689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0d9ba58da891921fafbfe7c6db358b51965e178 Gerrit-Change-Number: 15689 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2020 08:53:47 +0000 Gerrit-HasComments: Yes
