Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15689 )
Change subject: IMPALA-9625: Convert the name of a TAccessEvent to lowercase ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Thanks Fang-Yu, since the exhaustive tests passed, I think it is good to go in now. http://gerrit.cloudera.org:8080/#/c/15689/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/15689/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2758 PS1, Line 2758: public void addAccessEvent(TAccessEvent event) { > Hi Norbert, I just realized that simply adding "Preconditions.checkState(ev Hi Fang-Yu, I agree, this looks like the safer option. -- To view, visit http://gerrit.cloudera.org:8080/15689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0d9ba58da891921fafbfe7c6db358b51965e178 Gerrit-Change-Number: 15689 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Fri, 10 Apr 2020 14:52:24 +0000 Gerrit-HasComments: Yes
