Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 )
Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15683/3/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/15683/3/common/thrift/PlanNodes.thrift@124 PS3, Line 124: BLOOM_MIN_MAX = 2 > BTW forgot that I took some measurements of the ApplyPredicatePrimitive per Thanks Bankim, Todd for the.illustrative explanation. Agreed, for the (compound) primary keys, the min-max predicate is well suited for range pruning - that was my thought too in my initial comment. For #3, I didn't think it would provide much benefit but your numbers look compelling enough for the 'with predicate' case that it seems worth it. It sounds like Todd, you would even prefer evaluating that first. In that case, would the bloom filter be redundant ? It sounds like current behavior (from Bankim's comment) is the BF is evaluated first. In any case, yeah on further thought, the overhead of sending both is not too much and we could leave the decision making to Kudu. -- To view, visit http://gerrit.cloudera.org:8080/15683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9100076f68ea299ddb6ec8bc027cac7a47f5d754 Gerrit-Change-Number: 15683 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 10 Apr 2020 05:47:36 +0000 Gerrit-HasComments: Yes
