Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 )
Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15683/4/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/15683/4/common/thrift/PlanNodes.thrift@124 PS4, Line 124: MIN_MAX = 2 > It's possible that the comma separated list thing is a bad idea and won't w Query option setting is treated i as a string in impala-shell. We can set the option value with comma in impala-shell. But we will get parsing error in function impala::ParseQueryOptions() since comma is used as separator of a list of query option KV string, like "runtime_filter_min_size=1024, runtime_filter_max_size=65536". If we set "enabled_runtime_filter_type=bloom, min_max", the function parse the string as two KV string "enabled_runtime_filter_type=bloom," and "min_max". It get parsing error when parsing second KV string "min_max" since there is no "=" in the KV string. As discussed offline, we will not support comma separated filter types. Instead, rename BLOOM_MIN_MAX to ALL. -- To view, visit http://gerrit.cloudera.org:8080/15683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9100076f68ea299ddb6ec8bc027cac7a47f5d754 Gerrit-Change-Number: 15683 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 23 Apr 2020 06:37:39 +0000 Gerrit-HasComments: Yes
