Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15708 )
Change subject: Put transactional tables into 'managed' directory ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thanks Zoltan for the quick fix. Change looks good to me. Just have one small question. http://gerrit.cloudera.org:8080/#/c/15708/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/15708/1/testdata/datasets/functional/functional_schema_template.sql@289 PS1, Line 289: CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name} ( Just curious, if file format is orc and transnational does not set here. So this table is actually created as a managed table? -- To view, visit http://gerrit.cloudera.org:8080/15708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3b65f56bf7f225b1d29aa397f987fdd7eb7176c Gerrit-Change-Number: 15708 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Alice Fan <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 10 Apr 2020 18:17:00 +0000 Gerrit-HasComments: Yes
