Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15708 )
Change subject: Put transactional tables into 'managed' directory ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15708/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/15708/1/testdata/datasets/functional/functional_schema_template.sql@289 PS1, Line 289: CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name} ( > Just curious, if file format is orc and transnational does not set here. So No, because we have this CREATE section we'll just use this CREATE TABLE statement to create the table. And since it doesn't set the table as transactional this will remain a plain old non-transactional table. Currently we only promote tables to transactional tables that don't have custom CREATE sections. At L335 I added a TABLE_PROPERTIES section to make the non-transactinal property explicit. http://gerrit.cloudera.org:8080/#/c/15708/1/testdata/datasets/functional/functional_schema_template.sql@335 PS1, Line 335: ---- TABLE_PROPERTIES : transactional=false > Let me double check my understanding: this is needed because this is an ext Exactly. Without it we'd try to make it transactional in generate-schema-statements.py and set hdfs_location to point into the managed directory. However, since it has a specific CREATE statement that doesn't configure it as transactional, we'd end up with an external non-transactional table that is located in the managed dir. And Hive already prohibit external tables inside the managed dir. So these tables weren't transactional earlier either (due to the CREATE section), we are just making it explicit now. -- To view, visit http://gerrit.cloudera.org:8080/15708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3b65f56bf7f225b1d29aa397f987fdd7eb7176c Gerrit-Change-Number: 15708 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Alice Fan <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Apr 2020 20:08:08 +0000 Gerrit-HasComments: Yes
