Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15715
to look at the new patch set (#4).
Change subject: IMPALA-9643: fix runtime filter race for mt_dop
......................................................................
IMPALA-9643: fix runtime filter race for mt_dop
The fix is to set the consumer filter from the producer filter if it had
previously arrived.
Most of the code change is adding test infrastructure and fixing
TestRuntimeRowFilters to work with mt_dop=4 (it was accidentally not
enabled before). That mostly involved modifying the tests to use
aggregates of counters instead of picking out lines with regexes.
Testing:
Added a regression test that reliably failed before this
fix. This relies on extending debug actions to allow longer
delays, plus a minor extension to the RUNTIME_PROFILE .test
file parser to handle spaces in counter names.
Ran exhaustive tests.
Change-Id: I194c0d2515b6a0e5474e1c0c8647f0e54dc94397
---
M be/src/exec/exec-node.cc
M be/src/runtime/runtime-filter-bank.cc
M common/thrift/PlanNodes.thrift
A
testdata/workloads/functional-query/queries/QueryTest/runtime_row_filter_reservations.test
M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test
M tests/common/test_result_verifier.py
M tests/query_test/test_runtime_filters.py
7 files changed, 134 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/15715/4
--
To view, visit http://gerrit.cloudera.org:8080/15715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I194c0d2515b6a0e5474e1c0c8647f0e54dc94397
Gerrit-Change-Number: 15715
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
