Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 )
Change subject: IMPALA-9643: fix runtime filter race for mt_dop ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15715/4/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: http://gerrit.cloudera.org:8080/#/c/15715/4/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test@8 PS4, Line 8: # With filtering, expect 618 rows from alltypes and 2 from alltypestiny. Its not clear to me what these values are supposed to mean - it seems like this is saying that 618 rows from alltypes will pass the filter, but then I would expect "rows rejected" = (7300 - 618) != 7299 -- To view, visit http://gerrit.cloudera.org:8080/15715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c0d2515b6a0e5474e1c0c8647f0e54dc94397 Gerrit-Change-Number: 15715 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 13 Apr 2020 18:30:20 +0000 Gerrit-HasComments: Yes
