Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 )
Change subject: IMPALA-9643: fix runtime filter race for mt_dop ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15715/4/be/src/runtime/runtime-filter-bank.cc File be/src/runtime/runtime-filter-bank.cc: http://gerrit.cloudera.org:8080/#/c/15715/4/be/src/runtime/runtime-filter-bank.cc@118 PS4, Line 118: ret = obj_pool_.Add(new RuntimeFilter(filter_desc, filter_desc.filter_size_bytes)); > any reason we lazily create these filters when instances register? We actua This was a great suggestion and simplifies RuntimeFilterBank a lot. http://gerrit.cloudera.org:8080/#/c/15715/4/be/src/runtime/runtime-filter-bank.cc@128 PS4, Line 128: filter_desc.is_broadcast_join > is it possible to also hit the same issue with non-broadcast joins. It will I *think* this avoided by having QueryState::PublishFilter() call WaitForPrepare(). But that is kinda brittle and creating all filters upfront makes it more obviously correct. -- To view, visit http://gerrit.cloudera.org:8080/15715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c0d2515b6a0e5474e1c0c8647f0e54dc94397 Gerrit-Change-Number: 15715 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 13 Apr 2020 23:32:49 +0000 Gerrit-HasComments: Yes
