Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )
Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15700/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15700/1//COMMIT_MSG@16 PS1, Line 16: was was nit: typo http://gerrit.cloudera.org:8080/#/c/15700/1/be/src/runtime/collection-value-builder.h File be/src/runtime/collection-value-builder.h: http://gerrit.cloudera.org:8080/#/c/15700/1/be/src/runtime/collection-value-builder.h@65 PS1, Line 65: have_debug_action_ What is the point of introducing a member for this? Can't you do "!state->query_options().debug_action.empty()" here? Is this a perf optimisation? http://gerrit.cloudera.org:8080/#/c/15700/1/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/15700/1/tests/query_test/test_nested_types.py@148 PS1, Line 148: with memory limits tuned for : a 3-node HDFS minicluster This part of the comment is no longer true, right? -- To view, visit http://gerrit.cloudera.org:8080/15700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21 Gerrit-Change-Number: 15700 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Apr 2020 08:20:05 +0000 Gerrit-HasComments: Yes
