Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15700
to look at the new patch set (#2).
Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................
IMPALA-9596: deflake test_tpch_mem_limit_single_node
This changes the test to use a debug action instead of
trying to hit the memory limit in the right spot, which
has tended to be flaky. This still exercises the error
handling code in the scanner, which was the original
point of the test (see IMPALA-2376).
This revealed an actual bug in the ORC scanner, where
it was not returning the error directly from
AssembleCollection(). Before I fixed that, the scanner
got stuck in an infinite loop when running the test.
Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/collection-value-builder.h
A
testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-errors.test
D
testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
5 files changed, 34 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15700/2
--
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Norbert Luksa <[email protected]>
