Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1703 PS1, Line 1703: finalizeParams.setStaging_dir( : hdfsTable.getHdfsBaseDir() + "/_impala_insert_staging"); > It doesn't control where Impala puts the files, but it controls which direc My idea here is not to fix it, but to remove this member from thrift, as it falsely creates the illusion that this can be controlled from Frontend. If we make this actually configurable from a flag/query option in the future, this member still won't make sense, as flags/query options can be easily accessed from backend. I don't mind if you don't remove this now, but a TODO could be useful here to warn people that some parts of the backend do not respect this setting. -- To view, visit http://gerrit.cloudera.org:8080/15737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460 Gerrit-Change-Number: 15737 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 16 Apr 2020 13:28:58 +0000 Gerrit-HasComments: Yes
