Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15737 )

Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory 
during transactional INSERTs
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1703
PS1, Line 1703:         // TODO: Currently this flag only controls the removal 
of the query-level staging
              :         // directory. HdfsTableSink (that creates the staging 
dir) c
> My idea here is not to fix it, but to remove this member from thrift, as it
Added TODO comment.



--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 20 Apr 2020 13:59:15 +0000
Gerrit-HasComments: Yes

Reply via email to