Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 )
Change subject: IMPALA-9663: Fix for NPE in fire listener events ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15745/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/15745/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1062 PS2, Line 1062: Collections.EMPTY_LIST; > Is this same as Collections.emptyList();? yes, its the same. Collections.emptyList() returns Collections.EMPTY_LIST internally with the addition that it typecasts it to the expected type. -- To view, visit http://gerrit.cloudera.org:8080/15745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfcc5acd598fb0354a5a8288df7c495359f9e53d Gerrit-Change-Number: 15745 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Fri, 17 Apr 2020 01:29:24 +0000 Gerrit-HasComments: Yes
