Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15745 )
Change subject: IMPALA-9663: Fix for NPE in fire listener events ...................................................................... IMPALA-9663: Fix for NPE in fire listener events IMPALA-8632 introduced a improvement to Events processor which issues a new HMS API call to fire INSERT events when table and partitions are inserted into. However, if there is no new events generated HMS does not set the eventIds field in the response. This fix adds a check to not fire the listener events in such cases. Also, adds a check to make sure that eventIds are set in the response. Testing: 1. Added a test sql in test_event_processing.py which was failing with a NPE before the fix. Change-Id: Ibfcc5acd598fb0354a5a8288df7c495359f9e53d Reviewed-on: http://gerrit.cloudera.org:8080/15745 Reviewed-by: Anurag Mantripragada <[email protected]> Reviewed-by: Xiaomeng Zhang <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Quanlong Huang <[email protected]> --- M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M tests/custom_cluster/test_event_processing.py 3 files changed, 29 insertions(+), 6 deletions(-) Approvals: Anurag Mantripragada: Looks good to me, but someone else must approve Xiaomeng Zhang: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Quanlong Huang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibfcc5acd598fb0354a5a8288df7c495359f9e53d Gerrit-Change-Number: 15745 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]>
