Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 )
Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/15796/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15796/4//COMMIT_MSG@21 PS4, Line 21: remove delete Fixup redundant language http://gerrit.cloudera.org:8080/#/c/15796/4/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15796/4/fe/pom.xml@1406 PS4, Line 1406: <dependency> : <groupId>org.apache.sentry</groupId> : <artifactId>sentry-core-common</artifactId> : <exclusions> : <exclusion> : <groupId>org.apache.shiro</groupId> : <artifactId>shiro-crypto-cipher</artifactId> : </exclusion> : <exclusion> : <groupId>org.apache.shiro</groupId> : <artifactId>shiro-core</artifactId> : </exclusion> : </exclusions> : </dependency> I haven't use the dependencyManagement section. What is the significance of this being in the "dependencyManagement" section rather than a normal "dependencies" section? When would you pick one over the other? http://gerrit.cloudera.org:8080/#/c/15796/4/fe/pom.xml@1422 PS4, Line 1422: sentry-provider-db This artifact is listed here as well as above in the dependencies section, and it has other exclusions there. How does that work? -- To view, visit http://gerrit.cloudera.org:8080/15796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f9994bf81c1d2e025a03925e8eccb147c34d66e Gerrit-Change-Number: 15796 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 27 Apr 2020 23:19:47 +0000 Gerrit-HasComments: Yes
