Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 )
Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15796/4/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15796/4/fe/pom.xml@1406 PS4, Line 1406: <dependency> : <groupId>org.apache.sentry</groupId> : <artifactId>sentry-core-common</artifactId> : <exclusions> : <exclusion> : <groupId>org.apache.shiro</groupId> : <artifactId>shiro-crypto-cipher</artifactId> : </exclusion> : <exclusion> : <groupId>org.apache.shiro</groupId> : <artifactId>shiro-core</artifactId> : </exclusion> : </exclusions> : </dependency> > So, with this being my first foray into doing anything with maven, I'll con I have sympathy for trying to find a way to get rid of these dependencies. It's whack-a-mole. Exclusions go on top level artifacts listed in the pom (the root of the tree) and apply to the entire tree starting with that artifact. They don't apply to the tree for any other top level artifact, so the exclusion needs to go on every top level artifact that has the banned artifact in its tree. There is no need to add exclusions for artifacts that are not listed in our pom. Long story short, there are only so many moles to whack. Our pom.xml has multiple profiles (one for Hive 2, one for Hive 3), so it is important to add the exclusion for the right profile. (This doesn't apply to the shiro exclusion, but it does apply to netty.) This is not making use of any special functionality of dependencyManagement. These are regular exclusions that work just as well in the ordinary location. Move these exclusions up to the regular exclusion section for each of these artifacts. -- To view, visit http://gerrit.cloudera.org:8080/15796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f9994bf81c1d2e025a03925e8eccb147c34d66e Gerrit-Change-Number: 15796 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2020 02:11:45 +0000 Gerrit-HasComments: Yes
