Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 )
Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml@1386 PS3, Line 1386: <!-- IMPALA-9648: Avoid pulling in netty --> : <dependency> : <groupId>org.apache.hadoop</groupId> : <artifactId>hadoop-hdfs</artifactId> : <exclusions> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>*</artifactId> : </exclusion> : </exclusions> : </dependency> : <dependency> : <groupId>org.apache.hadoop</groupId> : <artifactId>hadoop-distcp</artifactId> : <exclusions> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>*</artifactId> : </exclusion> : </exclusions> : </dependency> : <dependency> : <groupId>org.apache.hadoop</groupId> : <artifactId>hadoop-common</artifactId> : <exclusions> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>*</artifactId> : </exclusion> : </exclusions> : </dependency> : <!-- end IMPALA-9648 --> I think that this code block doesn't exclude anything. If we were excluding * from io.netty, then the version on the ban shouldn't matter. Is there a reason we didn't add these as exclusions on the packages up in the normal dependencies section? -- To view, visit http://gerrit.cloudera.org:8080/15829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d61af3c10ee439ca9eef3840403229e6235c97 Gerrit-Change-Number: 15829 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 28 Apr 2020 22:42:40 +0000 Gerrit-HasComments: Yes
