David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 )
Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml@762 PS3, Line 762: (,4.1.46] > Cherry-picking onto asf-master, if we change the version to * and USE_CDP-H TL;DR On ASF master, if we do nothing and USE_CDP_HIVE=false, we wind up with 4.1.42.Final On ASF master, if we do nothing and USE_CDP_HIVE=true, we wind up with 4.1.47.Final On CDP master, if we do nothing, we wind up with 4.1.48.Final On ASF master, if exclude/ban * and USE_CDP_HIVE=false, the build succeeds On ASF master, if exclude/ban * and USE_CDP_HIVE=true, the build fails On CDP master, if exclude/ban *, the build fails The Black Duck scan only flags versions < 4.1.46 It looks like CDP Hive has updated their version of netty-all to 4.1.47 or 4.1.48 (I'm not sure why we see both versions) so maybe we actually don't have to do anything as long as USE_CDP_HIVE=true. Or maybe all we have to do is exclude versions < 4.1.46, per the Black Duck advice. -- To view, visit http://gerrit.cloudera.org:8080/15829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d61af3c10ee439ca9eef3840403229e6235c97 Gerrit-Change-Number: 15829 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2020 16:57:50 +0000 Gerrit-HasComments: Yes
