Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15807 )
Change subject: IMPALA-9539: Enable CNF rewrites by default ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15807/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java File fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java: http://gerrit.cloudera.org:8080/#/c/15807/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@114 PS5, Line 114: cpred = (CompoundPredicate) (cpred.clone()); Quanlong, the changes in this file are the only.additional change compared to what you had reviewed earlier. I found that if no transformation is done to the expression, we should return the original expr instead of the analyzed one because otherwise there were couple of test failures related to constant propagation ( one in constant-propagation.test and one in hdfs.test). I re-ran the gerrit-verify-dryrun to confirm all tests passed. Could you pls review this additional change ? Thanks. -- To view, visit http://gerrit.cloudera.org:8080/15807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dde86e092c61d71ddf9081f768072ced470b589 Gerrit-Change-Number: 15807 Gerrit-PatchSet: 5 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 30 Apr 2020 03:11:31 +0000 Gerrit-HasComments: Yes
