Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15807 )
Change subject: IMPALA-9539: Enable CNF rewrites by default ...................................................................... IMPALA-9539: Enable CNF rewrites by default This patch enables the conjunctive normal form rewrites by default by setting enable_cnf_rewrites to true. Since the CNF rule does an explicit analyze of the predicate if it was not previously analyzed, in case no rewrite was done we were previously returning the analyzed predicate. This causes some side effects hence I have fixed it by returning the original un-analyzed predicate when no rewrite is done. Other functional and performance testing with this flag set to true did not uncover major regressions and showed significant performance gains for queries with disjunctions in the tpch and tpcds suites. Testing: - Updated the PlannerTest tests with plan changes in various test suites. Removed previously added tpch tests which were explicitly setting this flag to true. - I had previously added a test in convert-to-cnf.test with enable_cnf_rewrites=false, so I did not add any new tests with this flag disabled. Change-Id: I4dde86e092c61d71ddf9081f768072ced470b589 Reviewed-on: http://gerrit.cloudera.org:8080/15807 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M common/thrift/ImpalaInternalService.thrift M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test M testdata/workloads/functional-planner/queries/PlannerTest/tpch-all.test M testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test M testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test M testdata/workloads/functional-planner/queries/PlannerTest/tpch-views.test 9 files changed, 505 insertions(+), 662 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4dde86e092c61d71ddf9081f768072ced470b589 Gerrit-Change-Number: 15807 Gerrit-PatchSet: 7 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
