Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 )
Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15829/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15829/4//COMMIT_MSG@12 PS4, Line 12: An earlier attempt (since reverted) had also tried to ban netty 3.10.5, : which also shows up in security scans, but since that jar is present in : some environments, banning it will cause builds to fail. There may be : a follow-up patch to address netty separately. I believe the new patch will also ban netty, so please revise this comment. http://gerrit.cloudera.org:8080/#/c/15829/4//COMMIT_MSG@17 PS4, Line 17: cdpd-master Apache projects expect that communications happen in a way that any member of the community can participate. References to non-public systems or terminology are discouraged. There is no way for anyone to know who or what cdpd-master is or why cherrypicking something on to it matters. Please remove this reference. But it is useful to know how this patch was tested. -- To view, visit http://gerrit.cloudera.org:8080/15829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d61af3c10ee439ca9eef3840403229e6235c97 Gerrit-Change-Number: 15829 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Sat, 02 May 2020 00:32:29 +0000 Gerrit-HasComments: Yes
