David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 )
Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download ...................................................................... Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > > > > > > > Patch Set 3: > > > > > > > > # with USE_CDP_HIVE=false > > > > Found Banned Dependency: io.netty:netty-all:jar:4.1.17.Final > > > > > > Sorry -- copy/paste error. That should be: > > > > > > # with USE_CDP_HIVE=true > > > Found Banned Dependency: io.netty:netty-all:jar:4.1.17.Final > > > > I'm realizing there might be a profiles-related confusion on my > > end. Let me double check. > > I was about to comment that probably the biggest subtle sticking point is the > profile stuff. The Hive 2 profile is only for USE_CDP_HIVE=false. The Hive 3 > profile is only for USE_CDP_HIVE=true. They have duplication, and that is a > minefield. Here is my solution: > https://gerrit.cloudera.org/#/c/15837/ Thanks -- I would honestly never have gotten this on my own. After I realized my profile mixup, I was able to get asf master and cdp master to build, but asf master with USE_CDP_HIVE=false is still failing, even though netty-all was *not showing up* in the mvn dependency:tree output at all. $ USE_CDP_HIVE=false ./buildall.sh -skiptests <etc.> still fails with: 11:28:29 [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message: Found Banned Dependency: io.netty:netty-all:jar:4.1.42.Final And yet, there's no netty-all to be found here... $ mvn dependency:tree -Dverbose > /tmp/netty_cdp_false.txt $ grep netty-all /tmp/netty_cdp_false.txt $ Turns out, it's the exclusion in <artifactId>hive-hbase-handler</artifactId> that fixed this, but I wouldn't have known that, without simply trying every node. -- To view, visit http://gerrit.cloudera.org:8080/15829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d61af3c10ee439ca9eef3840403229e6235c97 Gerrit-Change-Number: 15829 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 01 May 2020 18:36:47 +0000 Gerrit-HasComments: No
