Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 )
Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 ...................................................................... Patch Set 6: (7 comments) Found some formatting and comment consistency nits. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.h File be/src/codegen/codegen-anyval.h: http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.h@90 PS6, Line 90: #ifdef __aarch64__ nit: It is possible that clang did not catch this. The preprocessor directives are generally not indented in the Impala code base. This reoccurs multiple places. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.h@91 PS6, Line 91: // add conversion function here which convert val type between aarch64 and x86 nit: This could simply describe the method instead the intent behind it, for example: Conversion function which converts val type between aarch64 and x86. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.h@94 PS6, Line 94: nit: Missing function description. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.h@101 PS6, Line 101: /// Same as above but wraps the result in a CodegenAnyVal. nit: By inserting the above two methods this comment became obsolete. Maybe ChangeRetType and CreateCallWithChangeRetType should come after this method. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.cc@185 PS6, Line 185: // add conversion function here which convert val type between aarch64 and x86 nit: This comment is not necessary, the description is available in the header. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/codegen/codegen-anyval.cc@270 PS6, Line 270: nit: Empty line. http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: http://gerrit.cloudera.org:8080/#/c/15718/6/be/src/exec/text-converter.cc@310 PS6, Line 310: // For Decimal values, the return type generated by Clang is struct type rather than : // integer so casting is necessary nit: With the new condition this comment became obsolete, could you update this comment. -- To view, visit http://gerrit.cloudera.org:8080/15718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11 Gerrit-Change-Number: 15718 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2020 20:25:05 +0000 Gerrit-HasComments: Yes
