[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 )
Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/15718/9/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/15718/9/be/src/codegen/llvm-codegen.cc@113 PS9, Line 113: adx,aes,avx,avx2,bmi,bmi2,cmov,cx16,f16c," : "fma,fsgsbase,hle,invpcid,lzcnt,mmx,movbe,pclmul,popcnt,prfchw,rdrnd,rdseed,rtm,smap," : "sse,sse2,sse3,sse4.1,sse4.2,ssse3,xsave,xsaveopt, > Are these cpu attributes relevant on aarch64? Hi, Tamas, these are not relevant on aarch64, but these will also not be detected. Anyway I can remove them. http://gerrit.cloudera.org:8080/#/c/15718/9/be/src/codegen/llvm-codegen.cc@117 PS9, Line 117: The default flags are a known-good set that are " : "routinely tested. > Does this sentence remain true in aarch64 context? Yes, these attrs are routinely used in aarch64 context, but still cannot be said 'tested' in Impala LLVM codegen, because the aarch64 version of Impala is still in developing progress. If you don't want see this sentence, I can remove it. -- To view, visit http://gerrit.cloudera.org:8080/15718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11 Gerrit-Change-Number: 15718 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2020 03:02:39 +0000 Gerrit-HasComments: Yes
