Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15854 )
Change subject: IMPALA-9597: Eliminate redundant Ranger audits for column masking ...................................................................... Patch Set 3: Hi Csaba and Quanlong, I just found that I forgot to change my commit message accordingly. For the sentence "Specifically, instead of updating the List of AuthzAuditEvent's of the corresponding RangerBufferAuditHandler immediately after the deduplication, we clear this List first and add the deduplicated events back to the List only if there is no AuthorizationException.", I would like to change that to "Specifically, we stash the audit events after the analysis of the query and will deduplicate the stashed events and add back those deduplicated events only if the authorization of the query is successful." I will do this when addressing your comments in the next iteration. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/15854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d60130fba93d63fbc36949f2bf746b7ae2497d Gerrit-Change-Number: 15854 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2020 22:16:18 +0000 Gerrit-HasComments: No
