Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15854 )
Change subject: IMPALA-9597: Eliminate redundant Ranger audits for column masking ...................................................................... Patch Set 3: Code-Review+1 (2 comments) The solution looks good to me. Commented a minor optimization that may save some codes. http://gerrit.cloudera.org:8080/#/c/15854/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15854/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@184 PS3, Line 184: ((RangerAuthorizationContext) authzCtx).applyDeduplicatedStashedAuditEvents(); We can merge these two calls into one if we use a Map to track the stashed events. http://gerrit.cloudera.org:8080/#/c/15854/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java: http://gerrit.cloudera.org:8080/#/c/15854/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java@40 PS3, Line 40: private List<AuthzAuditEvent> stashedAuditEvents_; Can we use a Map for this? Then we don't need to call deduplicateStashedAuthzEvents and don't need two lists here. -- To view, visit http://gerrit.cloudera.org:8080/15854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d60130fba93d63fbc36949f2bf746b7ae2497d Gerrit-Change-Number: 15854 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2020 03:52:38 +0000 Gerrit-HasComments: Yes
