Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@569 PS15, Line 569: "true with an managed Kudu table.", IcebergTable.TBL_PROP_EXTERNAL_TABLE_PURGE)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@107 PS15, Line 107: throw new AnalysisException("Iceberg table does not have PartitionSpec: " + table_.getFullName()); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@252 PS15, Line 252: // Non-partition iceberg table only has one PartitionSpec with an empty PartitionField set line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15797/15/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@152 PS15, Line 152: createIcebergType(mapType.getKeyType()), createIcebergType(mapType.getValueType())); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/15797/15/tests/custom_cluster/test_iceberg.py File tests/custom_cluster/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/15797/15/tests/custom_cluster/test_iceberg.py@22 PS15, Line 22: class TestCreatingIcebergTable(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 15 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Sat, 09 May 2020 13:04:16 +0000 Gerrit-HasComments: Yes
