wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 16: (3 comments) Thanks for your review again, Zoltan. I've already modify the code. Besides, I update iceberg dependency version to 0.8.0-incubating, supported timestamp/date/decimal/array/map/struct data type and HOUR/DAY/YEAR partition transform in query, and also add some test cases. If there any problem, I will adjust as soon as possible. http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2544 PS14, Line 2544: } : } : : msClient.getHiveClient().createTable(newTable); : } else { > Might be safer to use MetastoreShim.getPathForNewTable() to avoid subtle bu Done http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@53 PS14, Line 53: > nit: tableLocation? Done http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@62 PS14, Line 62: > nit: operations? Done -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 16 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Sat, 09 May 2020 14:07:00 +0000 Gerrit-HasComments: Yes
