Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 )
Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list ...................................................................... Patch Set 8: Code-Review+2 (9 comments) I only found a pack of nits. http://gerrit.cloudera.org:8080/#/c/15818/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15818/8//COMMIT_MSG@30 PS8, Line 30: a visibilityTxnId and it is committed => every row is valid. nit: adding an example about how such a directory name looks would be nice http://gerrit.cloudera.org:8080/#/c/15818/8/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/15818/8/common/thrift/CatalogObjects.thrift@328 PS8, Line 328: high_watermak typo http://gerrit.cloudera.org:8080/#/c/15818/8/common/thrift/CatalogObjects.thrift@516 PS8, Line 516: 14 I prefer to keep the original numbers in thrift - I think the price is potentially 1 extra bit and we do not have to care about reading older version in Impala, but IMO this habit is still useful to make cherry-picking cleaner and this is how thrift should be generally used. http://gerrit.cloudera.org:8080/#/c/15818/7/fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/15818/7/fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java@374 PS7, Line 374: nit: +4 indentation http://gerrit.cloudera.org:8080/#/c/15818/7/fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java@383 PS7, Line 383: nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@611 PS8, Line 611: new BitSet() An empty bitset seems weird to pass to ValidReaderWriteIdList - null or an all 0 bitset with getInvalid_write_idsSize() seems to make more sense. Or ValidReaderWriteIdList expects it exactly this way? http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@618 PS8, Line 618: highWatermak typo? http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@623 PS8, Line 623: mapToLong(i -> i) I am not too familiar with Java streams. but do we need this? invalid_write_ids already contains longs (int64s in thrift), right? http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@255 PS8, Line 255: // TODO(todd) this should probably be a ValidWriteIdList in memory instead of a String. This TODO seems to be solved. -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2020 11:11:24 +0000 Gerrit-HasComments: Yes
