Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 )
Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list ...................................................................... Patch Set 9: (7 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/15818/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15818/8//COMMIT_MSG@30 PS8, Line 30: a visibilityTxnId and it is committed => every row is valid: > nit: adding an example about how such a directory name looks would be nice Done http://gerrit.cloudera.org:8080/#/c/15818/8/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/15818/8/common/thrift/CatalogObjects.thrift@328 PS8, Line 328: high_watermar > typo Done http://gerrit.cloudera.org:8080/#/c/15818/8/common/thrift/CatalogObjects.thrift@516 PS8, Line 516: 15 > I prefer to keep the original numbers in thrift - I think the price is pote I agree, done. http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@611 PS8, Line 611: new BitSet() > An empty bitset seems weird to pass to ValidReaderWriteIdList - null or an Hive's ValidReaderWriteIdList expects a non-null BitSet object. We don't need to set a size since BitSet.get(bitindex) only throws IndexOutOfBoundsException for negative values. For every other index the result is false for a default-constructed BitSet. https://docs.oracle.com/javase/7/docs/api/java/util/BitSet.html#get(int) http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@618 PS8, Line 618: highWatermar > typo? Same typo, different file :) Done. http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@623 PS8, Line 623: mapToLong(i -> i) > I am not too familiar with Java streams. but do we need this? invalid_write invalid_write_ids is a List<Long>. While we ValidReaderWriteIdList expects a long[]. mapToLong does the Long => long conversion. http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/15818/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@255 PS8, Line 255: protected ValidWriteIdList validWriteIds_ = null; > This TODO seems to be solved. Done -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2020 12:00:01 +0000 Gerrit-HasComments: Yes
