Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 )
Change subject: IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog ...................................................................... Patch Set 2: (2 comments) Thanks for taking a look at this! Revised the patch based on feedbacks. http://gerrit.cloudera.org:8080/#/c/15887/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/15887/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@693 PS1, Line 693: cached table > nit: I think it will be useful to mention the table name and database name Done http://gerrit.cloudera.org:8080/#/c/15887/1/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/15887/1/tests/hs2/test_hs2.py@476 PS1, Line 476: # The returned results should only contain metadata for the table and the view. > Maybe comment on what it's looping over and the order in which the table/vi Sure. BTW, the order doesn't matter since we verify table_type and table_remarks based on table_name. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2020 01:54:41 +0000 Gerrit-HasComments: Yes
