Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 )
Change subject: IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15887/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15887/2//COMMIT_MSG@21 PS2, Line 21: his patch fixes : the problem by adding an additional lookup in the local cache for the : table meta (hmsTable) of each table when creating the : LocalIncompleteTables If I understand correctly it is possible that if there are multiple coordinators with the load-balancer in front of them, we will may be seeing different sets of tables which are loaded and hence the table-type and comment information will keep flipping depending on which coordinator is serving the data. Do you think it will be simpler to always fetch the tablename, type and comment when we load the tableNames? Something like changing DbInfoSelector.want_table_names to DbInfoSelector.want_table_meta where meta includes tableName, type and comment. It doesn't seem like a big overhead given the benefit it provides will be a consistent view across coordinators. http://gerrit.cloudera.org:8080/#/c/15887/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/15887/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java@30 PS2, Line 30: */ nit, add a class comment which specifies that the LocalInCompleteTable could optionally have the msTbl object and scenarios when it will be present. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2020 20:02:54 +0000 Gerrit-HasComments: Yes
