Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 )
Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/15718/10/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: http://gerrit.cloudera.org:8080/#/c/15718/10/be/src/exec/text-converter.cc@306 PS10, Line 306: #ifdef __aarch64__ It'd be good to avoid #ifdefs in the middle of a statement. Change to something like: #ifdef __aarch64__ bool needs_cast = slot_desc->type().type == TYPE_DECIMAL || slot_desc->type().type == TYPE_DATE; #else bool needs_cast = slot_desc->type().type == TYPE_DECIMAL; #endif if (needs_cast) { -- To view, visit http://gerrit.cloudera.org:8080/15718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11 Gerrit-Change-Number: 15718 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 13 May 2020 20:50:16 +0000 Gerrit-HasComments: Yes
