Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15886 )
Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh ...................................................................... Patch Set 1: > Isn't this going to cause problems for people trying to build > Impala from a source tarball? > > Maybe this could be tweaked so that we only skip if we detect that > we're in a git checkout? Good point, I changed this to detect whether IMPALA_HOME is a git repository and avoid this check if it is not. -- To view, visit http://gerrit.cloudera.org:8080/15886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb70ef2d5048d5cfeb260ce62c34f04835c7132d Gerrit-Change-Number: 15886 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 15 May 2020 02:04:26 +0000 Gerrit-HasComments: No
