Hello Tim Armstrong, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15886
to look at the new patch set (#2).
Change subject: Only build ext-py directories tracked by git for
make_shell_tarball.sh
......................................................................
Only build ext-py directories tracked by git for make_shell_tarball.sh
When versions change in shell/ext-py/*, there can be leftover
directories when developers rebase. These leftover directories
are usually empty and unbuildable, so make_shell_tarball.sh will
fail with an error message like:
Creating an egg for .../Impala/shell/ext-py/bitarray-0.9.0
Traceback (most recent call last):
File "<string>", line 1, in <module>
IOError: [Errno 2] No such file or directory: 'setup.py'
...
This changes the build logic to only build directories that are
tracked in git. When a version of an ext-py package changes, the
directory for the old version may stick around, but it is gone from
the git repository and won't be built. The downside is that when
a developer is adding a new package version, it won't be built until
it is added in git. This logic is disabled if IMPALA_HOME is not a
git repository, which can happen when building from release tarballs.
Testing:
- Added an empty directory in shell/ext-py that was not tracked
in git. Verified it is not built (and would fail before).
- Tested the command detecting IMPALA_HOME as a git repository on
a non-repository directory.
Change-Id: Ibb70ef2d5048d5cfeb260ce62c34f04835c7132d
---
M shell/make_shell_tarball.sh
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/15886/2
--
To view, visit http://gerrit.cloudera.org:8080/15886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb70ef2d5048d5cfeb260ce62c34f04835c7132d
Gerrit-Change-Number: 15886
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
