Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )
Change subject: IMPALA-8860: Improve /log_level usability on WebUI ...................................................................... Patch Set 4: Hi Zoltan, thank you for updating the change. This comment became a bit long because it contains 'page design' in text :). The BE log level part looking good, additionally one slight change could help the users better understand the levels, the meaning of the numbers could be printed as well: https://impala.apache.org/docs/build/html/topics/impala_logging.html#log_levels ie.: 1: Default 2: Debug 3: All The FE log4j log levels could be collected as well, then there would be no need for the get log level part there. It can be cumbersome to get the levels one-by-one for every class manually. The 'LogManager.getCurrentLoggers()' can get all the loggers, then 'logger.getLevel()' should return 'null' or the log level if it is set. With the Java part it would be lot nicer and we could standardize the page layout a bit, ie (concept in text :) ).: [Text: Frontend log level configuration (log4j)] [Text: Current log level:] [Text or Textbox: Log4j level values class and level] [Text box: class] [Text: Log level:] [Combobox: level] [Button: Set Java Log Level] [Button: Reset Frontend Log Level] [Text: Backend log level configuration (glog)] [Text: Current log level:] [Glog level value] [Text: Log level] [Combobox: level] [Button: Set Glog Level] [Button: Reset Backend Log Level] Also, I am adding Zoltan Borok-Nagy as a reviewer, hope you have some time to take look at it. -- To view, visit http://gerrit.cloudera.org:8080/15903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33 Gerrit-Change-Number: 15903 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Garaguly <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Garaguly <[email protected]> Gerrit-Comment-Date: Fri, 15 May 2020 14:04:23 +0000 Gerrit-HasComments: No
