Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )
Change subject: IMPALA-8860: Improve /log_level usability on WebUI ...................................................................... Patch Set 6: Code-Review+1 (4 comments) Only found some style issues, other than that LGTM. I'm ready to upgrade my +1 to +2 once it looks good to Tamas. http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG@9 PS6, Line 9: h allows: nit: for log messages we use lines with 72 chars width. http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc File be/src/util/logging-support.cc: http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@143 PS6, Line 143: nit:extra space http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@233 PS6, Line 233: if (display_log4j_handlers) { : GetJavaLogLevels(doc); : } nit: fits single line as well http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift File common/thrift/Logging.thrift: http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift@48 PS6, Line 48: loglevels nit: we use underscores in member names, i.e. it should be log_levels -- To view, visit http://gerrit.cloudera.org:8080/15903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33 Gerrit-Change-Number: 15903 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Garaguly <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoltan Garaguly <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2020 09:36:23 +0000 Gerrit-HasComments: Yes
