Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )
Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java: http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@96 PS4, Line 96: "or 'STRING' but returns type '%s'.", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@831 PS4, Line 831: = ExtractCompoundVerticalBarExprRule.INSTANCE; tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/15877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf Gerrit-Change-Number: 15877 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Zink <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2020 07:23:45 +0000 Gerrit-HasComments: Yes
