Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )
Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15877/6/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/15877/6/be/src/exprs/expr-test.cc@3900 PS6, Line 3900: TestError ("cast('2011-10-22 09:10:11' as timestamp) || cast('2016-10-22 09:10:11' as timestamp)"); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/15877/6/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/15877/6/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@329 PS6, Line 329: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/15877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf Gerrit-Change-Number: 15877 Gerrit-PatchSet: 6 Gerrit-Owner: Martin Zink <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2020 11:58:13 +0000 Gerrit-HasComments: Yes
