Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15956 )
Change subject: IMPALA-9764: TransactionKeepalive should set sleep interval based on Hive Configuration ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15956/1/fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java File fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java: http://gerrit.cloudera.org:8080/#/c/15956/1/fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java@211 PS1, Line 211: HiveConf hiveConf = new HiveConf(TransactionKeepalive.class); > Can we always assume that there will be a hive-site.xml on the machine? Wha At least in my dev environment Impala won't start if it doesn't find a hive-site.xml. If the configuration value is missing from the hive-site.xml then the default value is used. Thanks for mentioning the HMS API. I gave it a try, it requires a bit more boilerplate code, but the main problem with it is that it can throw exceptions, therefore I'd need to update the throws clauses at several places. Since we are already using HiveConf at other places I think it's safe to depend on it here as well. -- To view, visit http://gerrit.cloudera.org:8080/15956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I546dac324494f1c945e8943e267f8146d22a837d Gerrit-Change-Number: 15956 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 15:31:25 +0000 Gerrit-HasComments: Yes
