Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15956 )

Change subject: IMPALA-9764: TransactionKeepalive should set sleep interval 
based on Hive Configuration
......................................................................

IMPALA-9764: TransactionKeepalive should set sleep interval based on Hive 
Configuration

Impala must heartbeat its transactions and locks in order to keep them
alive. Before this commit TransactionKeepalive had hard-coded value for
sleep interval, i.e. it slept 60 seconds between heartbeats.

However, at HMS side the transaction timeout is configurable.

With this commit Impala reads the Hive configuration and calculate its
sleep interval based on that. It simply divides the timeout value by 3.

Testing:

I tested it manually. Created hive-site.xml with "hive.txn.timeout" set
and checked that Impala picked up the set value. If "hive.txn.timeout"
was not set, Impala used the default value (300s).

Change-Id: I546dac324494f1c945e8943e267f8146d22a837d
Reviewed-on: http://gerrit.cloudera.org:8080/15956
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
1 file changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/15956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I546dac324494f1c945e8943e267f8146d22a837d
Gerrit-Change-Number: 15956
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>

Reply via email to