Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 )
Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list ...................................................................... Patch Set 14: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15818/13/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/15818/13/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2096 PS13, Line 2096: sw.elapsed(TimeUnit.NANOSECONDS) > To me it seems like storageMetadataLoadTime_ is only for time spent in file Ah yes. I thought loadSchema(), loadAllColumnStats() and loadConstraintsInfo() are just extracting meta from the loaded msTable object so they are not counted (since no external RPCs). I just realize that loadAllColumnStats() and loadConstraintsInfo() also trigger HMS RPCs. Thanks for the clarification! http://gerrit.cloudera.org:8080/#/c/15818/13/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/15818/13/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@405 PS13, Line 405: throw new NotImplementedException( > In CatalogdMetaProvider we load validWriteIdList together with catalog vers OK. In my understanding, DirectMetaProvider is a "toy" in the approach of removing the catalog server. And we finally turned to keep the catalog server and implement CatalogdMetaProvider. It may be revived someday. Let's skip this for now. -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 14 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2020 15:14:03 +0000 Gerrit-HasComments: Yes
