Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 )
Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/15818/15/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/15818/15/fe/src/main/java/org/apache/impala/util/AcidUtils.java@191 PS15, Line 191: if (!isTxnValid(pd.visibilityTxnId)) return false; > INSERT-only tables can only be major compacted, so it was enough to check t thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/15818/15/fe/src/main/java/org/apache/impala/util/AcidUtils.java@246 PS15, Line 246: visibilityTxnId > Yes. thanks -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 15 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 May 2020 17:16:17 +0000 Gerrit-HasComments: Yes
