Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 )
Change subject: Fix JIRA IMPALA-2658: Extend the NDV function to accept a precision ...................................................................... Patch Set 1: (21 comments) http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/agg-fn-evaluator.cc File be/src/exprs/agg-fn-evaluator.cc: http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/agg-fn-evaluator.cc@333 PS1, Line 333: bool isBuiltInNDV = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/agg-fn-evaluator.cc@336 PS1, Line 336: if ( isBuiltInNDV ) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/agg-fn-evaluator.cc@338 PS1, Line 338: // invoke it here with 2nd argument ignored as the argument is really not needed tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/agg-fn-evaluator.cc@341 PS1, Line 341: // It is worthwhile in the future to revisit this area to implement a general line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/agg-fn-evaluator.cc@346 PS1, Line 346: else tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions-ir.cc@1443 PS1, Line 1443: return 1 << abstractValue; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions-ir.cc@1444 PS1, Line 1444: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions-ir.cc@1540 PS1, Line 1540: harmonic_mean = 1.0 / harmonic_mean; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions-ir.cc@1542 PS1, Line 1542: // The actual harmonic mean value is hll_len * harmonic_mean below line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions.h File be/src/exprs/aggregate-functions.h: http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions.h@205 PS1, Line 205: // Define the min and the max of parameter m. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/be/src/exprs/aggregate-functions.h@217 PS1, Line 217: static uint64_t HllFinalEstimate(const uint8_t* buckets, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/Expr.java@549 PS1, Line 549: // Construct a type vector for fn_, covering all children, even when fn_ has line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/Expr.java@610 PS1, Line 610: // Construct a type vector for fn_, covering all children, even when fn_ has line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@477 PS1, Line 477: // values 17 and 18. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@480 PS1, Line 480: return 1 << abstractValue; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@481 PS1, Line 481: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@567 PS1, Line 567: // NDV() can optionally take a second argument must be an integer literal line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@578 PS1, Line 578: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@579 PS1, Line 579: if (abstractValue.getValue().scale() != 0 || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@580 PS1, Line 580: !NumericLiteral.fitsInInt(abstractValue.getValue()) || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@590 PS1, Line 590: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/15997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a4517bd0959f7021143073d37505a46c551a58 Gerrit-Change-Number: 15997 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2020 16:31:41 +0000 Gerrit-HasComments: Yes
